Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print error file path when using rollupOptions.output.dir (fix #9100) #9111

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

qmhc
Copy link
Contributor

@qmhc qmhc commented Jul 14, 2022

Description

fix #9110

Additional context

Current prints:

image

I think it's better to improve to print for each dir by groups, like the following:

lib/
  test.js ...
  other.js ...

es/
  test.mjs ...
  other.mjs ...

Should I do this?

One more point:

image

prepareOutDir only process the outDir and ignored dir in output config, is this expected?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 6b267bc
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cfef86cc59fa00099533cf

@bluwy
Copy link
Member

bluwy commented Aug 16, 2022

I think it's better to improve to print for each dir by groups, like the following:

I think it's worth exploring an alternative print display. The indent looks great to me!

prepareOutDir only process the outDir and ignored dir in output config, is this expected?

It's mostly because we only expect a single output or outDir in most cases, but I think it's worth tackling this too in another PR.

@patak-dev patak-dev merged commit 3bffd14 into vitejs:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print error file path when using rollupOptions.output.dir
3 participants